Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩 DOP-4060 adds new featrue flag to the docs-worker-pool #919

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

caesarbell
Copy link
Collaborator

This PR introduces the new feature flag for hiding the locale on the unified footer on the docs page in production and showing it for non-product environments.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

The URL for your feature branch webhook is https://e7rbwoye5e.execute-api.us-east-2.amazonaws.com/prod/

Copy link
Contributor

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM. on a minor note, seems like this env flag is set to false? /env/legacy/docs/worker_pool/flag/hide_locale not sure if we want to show the locale selection for legacy

@caesarbell
Copy link
Collaborator Author

this LGTM. on a minor note, seems like this env flag is set to false? /env/legacy/docs/worker_pool/flag/hide_locale not sure if we want to show the locale selection for legacy

@seungpark I can change this. Legacy is a non-production env correct?

Copy link
Contributor

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caesarbell caesarbell merged commit 12fbb16 into master Oct 3, 2023
7 checks passed
@schmalliso
Copy link
Contributor

this LGTM. on a minor note, seems like this env flag is set to false? /env/legacy/docs/worker_pool/flag/hide_locale not sure if we want to show the locale selection for legacy

@seungpark I can change this. Legacy is a non-production env correct?

It is, but it also probably doesn't matter since (a) the Legacy environment doesn't work and (b) doesn't build with the consistent nav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants